Dominik Panzer @PanzerDominik@sw-development-is.social

In case you missed the posting on #abapventcalendar, I published a modified #sap #abap version of the #refactoring kata "Lift Pass Pricing" by Johann Martinson. It includes some additional twists and new requirements. enjoy :-) https://abapventcalendar.com/advent-calendar/19-december-2022/

Here are the slides for my session „oh man, wer hat das denn bitte programmiert? Oh, das war ja ich“ @AbapConf
#abap #abapconf #sap https://intenseag-my.sharepoint.com/:b:/g/personal/dominik_panzer_intense_de/EVJWerInodBBqtlV_MaTRR8BHlc46PtQWo-AHRIcgOdVOg?e=WtAwgN includes screenshots for every refactoringstep. (Temporary link)
and the link to the refactoring kata "Meterdata Manager" https://github.com/dominikpanzer/ABAP-Meterdata-Manager

The next step will be to ask for a tiny bit of upfront design. basic sketches before implementing the next report and discuss the results.

but this time a new report needs to be developed. greenfrield :-) So this time its not enough that the report does fullfil the functional requirements... I'll introduce some NFRs: unit test and clear separation of concerns. he will start on his own and can ask questions anytime. then we will do some more pairing. I'm excited how the code will look like and if he did a tdd, test first or test last approach - and why.

so I've got a new colleague on one of my projects! great. we started pairing on a #abap report ... some c&p and adding some validations, security, testmode, logging, documentation and... well everything else you would expect from a good report 🤪. he finished the report alone. well done. he got some domain knowledge and I learned more about his current #abap skills. #pairprogramming is really good for onboarding ppl on your project. whats the next step? the customer has another requirement.🧵

do you want to know why "only a lazy #abap developer is a good developer"? check out the #abapventcalendar here: https://abapventcalendar.com/advent-calendar/4-december-2022/

some shops just dont want my money...

A 40 line method will grow by 10 lines just because of that fm-call and sy-subrc checks. Everything else were method calls. So we decided to put the fm-call into in a separate method. But oh no: my colleague uses SE80. No „extract method“ available. So we installed #adt. If you want #cleancode / clean #abap then you need to use a proper IDE. Or it wont happen.

So I am currently onboarding a new colleague. We do some pairprogramming. Today we helped out another colleague with an #abap problem. He had this nice method. 40 lines. A loop. Some message calls. Only one line of real logic. Quite eautiful. We found the problem fast. But wait! Its just unbelievable ugly to put a plain function module call inside of the loop. It just doesn’t fit. Its not the same layer of abstraction.